Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Mosaico JS files via composer-downloads-plugin #525

Merged
merged 1 commit into from
May 27, 2022

Conversation

totten
Copy link
Collaborator

@totten totten commented May 27, 2022

This should lighten the load on downloading from git (and also resolve #479).

  • Before: Clone the main Mosaico repo. Run a full JS toolchain (npm, node, bower, grunt, phantom) to create the compiled Mosaico JS.
  • After: Download pre-compiled Mosaico JS.

composer.json Outdated
"downloads": {
"mosaico": {
"path": "packages/mosaico",
"url": "https://github.com/totten/mosaico/releases/download/v0.15-civicrm-2.1/mosaico-dist.tar.gz"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pulls from a tag on totten/mosaico. However, if we merge civicrm/mosaico#13 first, then we can download from civicrm/mosaico instead.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@totten I merged civicrm/mosaico#13 can you update this PR now?

@mattwire mattwire merged commit 5baa528 into veda-consulting-company:2.x May 27, 2022
@mattwire
Copy link
Collaborator

Great thanks @totten I've merged. Let me know if there is anything else we need to do to make this work? Will need to update the docs for publishing each release

@totten
Copy link
Collaborator Author

totten commented May 27, 2022

FWIW, I had to re-tag civicrm/mosaico with new merge.

In terms of docs and publishing, the main thing is that we now have to treat the two repos as separate deliverables. So:

  • The common case of developing+releasing changes for the integration (uk.co.vedaconsulting.mosaico) should be faster/easier now.
  • The less common case of developing+releasing changes for the JS (mosaico) should be harder/slower now.
    • Development: Need to separately clone the additional git repo. Need to setup JS toolchain. etc
    • Release:
      • First, tag a new release on mosaico.git.
      • Wait 15 minutes. (It takes 14 minutes to execute npm install... mostly due to the bower substep...)
      • Then, edit uk.co.vedaconsulting.mosaico:composer.json to pull in the new JS build.
      • Then, do the release for uk.co.vedaconsulting.mosaico.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm and deprecated git:// URLs
2 participants