Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project's sass had not been compiled for 2 years, and in that time gulp has changed a lot, and after spending an hour or two trying to get gulp 4 working with the old gulpfile, I gave up.
This PR simplifies the compilation a lot; we now only depend on one npm package,
sass
, and we run it directly - see the compile-sass-to-css.sh file.Works for me!
I updated the docs, too.
As part of this work I realised that this extension depends on shoreditch, but only for building its css.
PS. I built this on top of #631 and there was a commit that didn't quite make it into that PR that's included in this. Other than that minor change, I don't think there were any other sass/css changes made.