-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional SVM variations #590
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: kalvdans <github@kalvdans.no-ip.org>
Doesn't vesc already use the ARS SVPWM type? You do get to eliminate the dead time for the low side phase, but that can actually provide important balancing and make the dead time for all phases equal and easier to compensate for / ignore. Have you tested this on any hardware at all? Tried with / without phase voltage filters? This would also effect the voltage sensing for hardware with low side current shunts vs phase voltage shunts. So this is not simple. and may not be desired in a lot of cases. It has actually been discussed before and not been found to be particularly valuable with it's tack on effects. At most this may be made selectable, but probably should not replace ARS SVPWM. If you aren't you should join us in the vesc discord. (Discord) Especially if you are really into motor control. The #esc-firmware thread is probably where you want to be for discussing this in depth. |
Nice work! I think you got the the VESC Tool update right too. Before merging I would like to see some more testing. As it looks to me now from the testing you did the additional methods reduce stability and whether they help with spreading heat or reducing the effects of dead time is not really confirmed. It would be good to see some experiments that show advantages and how current sensing and voltage sensing with phase filters is affected. |
Additional svm implementations
Fixes #589
https://youtu.be/5eQyoVMz1dY
https://link.gale.com/apps/doc/A18320578/AONE