Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter being apply to wrong column when using colReorder #107

Closed
luivis07 opened this issue Nov 17, 2014 · 7 comments
Closed

Filter being apply to wrong column when using colReorder #107

luivis07 opened this issue Nov 17, 2014 · 7 comments

Comments

@luivis07
Copy link

This issue occurs when using colReorder with yadcf. If a column is moved around and the column filter is applied after moving the column. The filtering will be performed in the original (initial) position that the column filter was in.
Sample fiddle: http://jsfiddle.net/e4685cug/ and to recreate issue: swap column "header4" with "header3" and apply a filter of 1.8 on "header4"

@vedmack
Copy link
Owner

vedmack commented Nov 29, 2014

What filter types are you using? So I will begin with those types first... because its not a small feature...

@luivis07
Copy link
Author

luivis07 commented Dec 4, 2014

Hi Daniel,
I'm using the freetext filter and dropdown mainly, so the ones included in the fiddle. I really appreciate the work you are doing so if you need help completing this enhancement I could do a pull request and help you out.

@vedmack
Copy link
Owner

vedmack commented Dec 4, 2014

Thanks, but I almost done with the colReorder support for the select / text filters anyway...

@luivis07
Copy link
Author

luivis07 commented Dec 5, 2014

Great! I really appreciate it. Thanks Daniel

@vedmack
Copy link
Owner

vedmack commented Dec 5, 2014

go grab the 0.8.7.beta.3 , added "Support (partial) for ColReorder (for filter_type 'select' and 'text') …"
your fiddle works now as expected

@vedmack vedmack closed this as completed Dec 5, 2014
@luivis07
Copy link
Author

luivis07 commented Dec 8, 2014

@vedmack thanks it seems to be working now, are you planning on adding this enhancement to the other filter types? We are eventually going to start using other types as well (specially multi_select and date)

@vedmack
Copy link
Owner

vedmack commented Dec 9, 2014

I do plan to add this to all filter types, but since the lack of time it will be better if you will open new issue for specific filter types so they'll get higher priority from me.

vedmack added a commit that referenced this issue Dec 19, 2014
rewrite the ColReorder for select / text filters #107
vedmack added a commit that referenced this issue Dec 19, 2014
rewrite the ColReorder for select / text filters #107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants