Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add equip slot to default sort #13

Open
veechs opened this issue Jan 4, 2025 · 0 comments
Open

Add equip slot to default sort #13

veechs opened this issue Jan 4, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@veechs
Copy link
Owner

veechs commented Jan 4, 2025

Currently, gear types are not grouped together (gloves with gloves, etc.) and probably should be in the default Sort Order.

Requested here.

@veechs veechs added the enhancement New feature or request label Jan 4, 2025
@veechs veechs self-assigned this Jan 4, 2025
@veechs veechs added this to the Bagshui 1.3 milestone Jan 11, 2025
veechs added a commit that referenced this issue Jan 18, 2025
- Change how sorting for Eqiup Location is handled. Previously, the game names (ex: INVTYPE_LEGS) or localized (ex: Legs) were offered. Both have been replaced with a custom sort based on character sheet order, working from top to bottom on the left, same on the right, then left to right at the bottom.
- Any existing Sort Orders containing either of the old Equip Location fields will be updated to use the new one.
- Sort Orders now get cleaned at startup and any invalid fields are removed.
- Added Equip Location to all the default Sort Orders (#13).
- As part of this change, inventory cache validation has been added. This should reduce the chance of errors due to item cache fields being added or removed.
- ItemInfo has been lightly refactored so it no longer needs to load so late. This was needed to support the cache validation code.
- ItemInfo:InitializeItem() has been updated to be usable for cache validation.
- InitializeEmptySlotItem() was moved from Inventory to ItemInfo, where it probably should have been all along.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant