refactor(typing): reduce type ignores in api.py

vega · Jul 15, 2024 · 6adf564 · 6adf564
1 parent bed0965
commit 6adf564
Show file tree

Hide file tree

Showing 4 changed files with 143 additions and 138 deletions.
diff --git a/altair/utils/schemapi.py b/altair/utils/schemapi.py
@@ -1071,10 +1071,7 @@ def _default_wrapper_classes(cls) -> Iterator[type[SchemaBase]]:
 
     @classmethod
     def from_dict(
-        cls: type[TSchemaBase],
-        dct: dict[str, Any],
-        validate: bool = True,
-        _wrapper_classes: Iterable[type[SchemaBase]] | None = None,
+        cls: type[TSchemaBase], dct: dict[str, Any], validate: bool = True, **kwds: Any
     ) -> TSchemaBase:
         """Construct class from a dictionary representation
 
@@ -1101,9 +1098,9 @@ def from_dict(
         """
         if validate:
             cls.validate(dct)
-        if _wrapper_classes is None:
-            _wrapper_classes = cls._default_wrapper_classes()
-        converter = _FromDict(_wrapper_classes)
+        converter = _FromDict(
+            kwds.pop("_wrapper_classes", cls._default_wrapper_classes())
+        )
         return converter.from_dict(dct, cls)
 
     @classmethod