Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version Altair on pyodide #3642

Closed
2 of 3 tasks
mattijn opened this issue Oct 17, 2024 · 5 comments
Closed
2 of 3 tasks

Update version Altair on pyodide #3642

mattijn opened this issue Oct 17, 2024 · 5 comments
Labels
enhancement

Comments

@mattijn
Copy link
Contributor

mattijn commented Oct 17, 2024 •
edited by dangotbanned
Loading

What is your suggestion?

Update the altair version integrated within pyodide, it is still on 5.3.0, with the latest version of altair, the hard dependencies are drastically reduced, which is good for loading time.

Related
@dangotbanned
Copy link
Member

@joelostblom may need to do this, since they are listed as the recipe maintainer.

I think this is the process to follow though:

@joelostblom
Copy link
Contributor

I ran the update steps locally and it seems to work fine. I can put up a PR and I'm happy to add anyone as a maintainer who wants to be on there. Before doing that however, I think we need someone to build a pyodide package for Narwhals since that is a new dependency that doesn't yet exist on pyodide?

@MarcoGorelli
Copy link
Contributor

I think we need someone to build a pyodide package for Narwhals since that is a new dependency that doesn't yet exist on pyodide?

on this 🏃

@MarcoGorelli MarcoGorelli mentioned this issue Oct 18, 2024
Merged
2 tasks
@joelostblom
Copy link
Contributor

Super, thank you @MarcoGorelli ! I put up the altair PR referencing yours for Narwhals pyodide/pyodide#5124

hoodmane pushed a commit to pyodide/pyodide that referenced this issue Oct 22, 2024
@MarcoGorelli
Add Narwhals to package list (#5121)
2cd495b 
Narwhals is a lightweight compatibility layer between dataframe libraries, with
zero dependencies. It's now used by Altair, so I'm opening this PR to enable
them to update their version here on Pyodide vega/altair#3642
@joelostblom
Copy link
Contributor

Closing this since pyodide/pyodide#5124 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@joelostblom @mattijn @MarcoGorelli @dangotbanned