-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lifting parameters to the top level #2702
Conversation
In multi-view charts, all parameters will live on the top level. When necessary, the parameters will specify which constituent charts they should be attached to.
The following example should be working on this branch.
|
@jakevdp @joelostblom @mattijn I think what's here is pretty much finalized. Are there any changes you'd like to see? For now I'm planning to switch focus to #2592 (comment) Thanks again @mattijn for all the help. |
Same changes as #2591
I added the changes from #2591 to this PR. Thanks @joelostblom for noticing #2591 had been mistakenly deleted! |
Aligning versions with those used by altair_viewer.
Thanks! All tests on Github Actions are passing.
Merging this🥳 |
Awesome seeing this merged, thank you both for your hard work on it! |
This should have the same functionality as #2684, just with a cleaner commit history. The only change in functionality from #2684 is that
layer
is allowed to be mixed withrow
or column in Repeat Charts.The main goal of this PR is to improve the behavior of parameters in multi-view charts (whether added at the top level or at the level of the constituent charts).
Thanks to @mattijn especially for the dozens of comments and examples.