Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aliases for ImputeParams and TitleParams #2732

Merged
merged 7 commits into from
Jan 5, 2023
Merged

Aliases for ImputeParams and TitleParams #2732

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c8db456
Aliases for ImputeParams and TitleParams
ChristopherDavisUCI Nov 30, 2022
be9a5bb
Merge remote-tracking branch 'upstream/master' into Aliases
ChristopherDavisUCI Jan 3, 2023
8e9a79e
Update altair/vegalite/v5/api.py
ChristopherDavisUCI Jan 3, 2023
7535c02
Remove StackOffset alias
ChristopherDavisUCI Jan 4, 2023
36bb2f9
Add a test related to aliases
ChristopherDavisUCI Jan 4, 2023
8e37ff3
Update tests/vegalite/v5/tests/test_alias.py
ChristopherDavisUCI Jan 4, 2023
62c02eb
Update tests/vegalite/v5/tests/test_alias.py
ChristopherDavisUCI Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions altair/vegalite/v5/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ def _prepare_data(data, context=None):
# ------------------------------------------------------------------------
# Aliases & specializations
Bin = core.BinParams
Impute = core.ImputeParams
Title = core.TitleParams
ChristopherDavisUCI marked this conversation as resolved.
Show resolved Hide resolved


@utils.use_signature(core.LookupData)
Expand Down
15 changes: 15 additions & 0 deletions tests/vegalite/v5/tests/test_alias.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import pytest

import altair.vegalite.v5 as alt


def test_aliases():
"""Ensure that any aliases defined in `api.py` aren't colliding with names already defined in `core.py` or `channels.py`."""
for alias in ["Bin", "Impute", "Title"]:
getattr(alt, alias)

with pytest.raises(AttributeError):
getattr(alt.core, alias)

with pytest.raises(AttributeError):
getattr(alt.channels, alias)
ChristopherDavisUCI marked this conversation as resolved.
Show resolved Hide resolved