feat(typing): adds Map alias for Mapping[str, Any]
#3458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a `TypedDict` to be used, where `mypy` previously would have required exactly a `dict`. The name is not used anywhere currently in `altair` and has the benefit of being short like `dict`, but more permissive. I have only added this to `Chart.encode` as I know this does not require the mutability of `dict`, which I cannot confidently say for elsewhere in `altair`. Fixes vega#3427 (comment)
|
Looks good to me, thanks! Agree that it would make sense to relax this type hint also in other places. |
32 tasks
dangotbanned
added a commit
to dangotbanned/altair
that referenced
this pull request
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a
TypedDictto be used, wheremypypreviously would have required exactly adict.The name does not conflict with any existing types/classes in
altairand has the benefit of being short likedict, but more permissive.I have only added this to
Chart.encodeas I know this does not require the mutability ofdict, which I cannot confidently say for elsewhere inaltair.A future PR could investigate other generated wrappers that use
dictand either reuseMapor add another alias to theEXTRA_ALIASESliteral.Fixes #3427 (comment)
Related https://mypy.readthedocs.io/en/stable/typed_dict.html#typeddict