Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Promote when-then-otherwise in User Guide #3544

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Commits on Aug 18, 2024

  1. docs: Replace some inline references

    No visual change, but makes the markup itself easier to read
    dangotbanned committed Aug 18, 2024
    Configuration menu
    Copy the full SHA
    e46a493 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Configuration menu
    Copy the full SHA
    abdcf3a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2024

  1. Configuration menu
    Copy the full SHA
    a365083 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9ca55a8 View commit details
    Browse the repository at this point in the history
  3. docs: Update waterfall_chart.py example

    - Replaced `dict` with `when-then-otherwise`
    - Replaced string expressions with `python` equivalent
    - Formatting update to avoid horizontal overflow
    dangotbanned committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    a681ec5 View commit details
    Browse the repository at this point in the history
  4. wip

    dangotbanned committed Aug 28, 2024
    Configuration menu
    Copy the full SHA
    f454093 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2024

  1. Configuration menu
    Copy the full SHA
    ab6c4b4 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Configuration menu
    Copy the full SHA
    3b72a83 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2024

  1. Configuration menu
    Copy the full SHA
    089759e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    729b7de View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1bc65ce View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f9277fa View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    961eb13 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d886fbe View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9ca591e View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    fe5f8e5 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b0893e2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    008ff8d View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    4fe1e9c View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6269533 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f08d96f View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Configuration menu
    Copy the full SHA
    60f859f View commit details
    Browse the repository at this point in the history
  2. docs(DRAFT): Use when in parameters.rst

    First draft version. Unlike the other commits, this has to introduce the concept - so will require more scrutiny.
    
    vega#3544 (comment)
    dangotbanned committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    1d6be16 View commit details
    Browse the repository at this point in the history
  3. docs: Proofread parameters.rst

    - Mostly correcting formatting issues.
    - Removed some immediately repeated info that followed `when`.
    - Added a ref to `alt.Chart`
    dangotbanned committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    d9899f5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e6a9b9c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    dfab00c View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. docs: Use when in arguments syntax examples (1/2)

    Covers all the examples that had a *methods* equivalent.
    Now have 16 more to do, across 12 files
    dangotbanned committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    ff0bc34 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    390d599 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e6790a9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3caf2e7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ebff622 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    731728e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    1a5c0b9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6d6b8a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Configuration menu
    Copy the full SHA
    222deb5 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. Configuration menu
    Copy the full SHA
    1c7663c View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. Configuration menu
    Copy the full SHA
    9ebb90b View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    f43d331 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. fix: Use selector argument in make_example

    All of the charts using this function were silently producing no output.
    `brush` had been defined globally in an earlier directive
    
    vega#3544 (comment)
    dangotbanned committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fb42da7 View commit details
    Browse the repository at this point in the history
  2. docs: Add new subsection content

    Not sure what the title should be, but @joelostblom proposed making this a new subsection
    
    vega#3544 (review)
    dangotbanned committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    50a520e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    df5555c View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Expand explanation of when

    To be able to fully document the behavior of `when`,
    I made a few organizational changes:
    
    - Split "Conditions" and "Filter" since these are two
      different concept anyways.
    - I also renamed the first heading to illustratet that
      the three big concepts are "Parameter", "Conditions", and "Filters".
    - Named the main new "when" section "Understanding when()"
      and included an example of conditional branches in pseudocode early on
      and a runnable example later.
    - I also added an additional subheading for "Linking across charts"
    - Included mention of the use of `empty=False` inside `when` together
      with a short pseudocode example.
    - Creating a new section at the end about combining parameters,
      which contains both the previous section on parameter composition,
      but also two new subsection on multiple conditions and conditional
      when branches.
    - I expanded on the parameter composition examples as well.
    joelostblom committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e363abd View commit details
    Browse the repository at this point in the history