Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set charset=UTF-8 in HTML templates. #3604

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

davidgroves
Copy link
Contributor

@davidgroves davidgroves commented Sep 20, 2024

I'm not sure if you want a more sophisticated approach, or even if this is user-error rather than a defect, but this at least fixed my immediate problem and may be "good enough" for the project.

@davidgroves davidgroves changed the title Fix for #3603: Set charset=UTF-8 in HTML templates. fix: Set charset=UTF-8 in HTML templates. Sep 20, 2024
Copy link
Contributor

@binste binste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thank you @davidgroves for the PR!

@binste binste merged commit 888c3e3 into vega:main Sep 21, 2024
15 checks passed
@binste binste added the bug label Sep 21, 2024
@davidgroves davidgroves deleted the meta_charset branch September 21, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using the browser renderer, no charset is set in the generated HTML
2 participants