Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(build): convert auto config file from TS to JSON #1413

Merged
merged 1 commit into from
Sep 21, 2022
Merged

fix(build): convert auto config file from TS to JSON #1413

merged 1 commit into from
Sep 21, 2022

Conversation

hydrosquall
Copy link
Member

@hydrosquall hydrosquall commented Sep 21, 2022 •
edited by github-actions bot
Loading

Motivation

Changes

  • Converts config file for the package used for our Auto releases from TS to JSON (a simpler file format since it's static / can't be executed). This will prevent the need for invoking any of the code in https://www.npmjs.com/package/@endemolshinegroup/cosmiconfig-typescript-loader , which is currently pinned to an old version of ts-node.
  • If this doesn't work, we can also force yarn to make this loader use a newer version of ts-node using selective dependency resolution. However, I'm leaving that as a last resort for a separate PR since it also comes with the risk of breaking other code if we forget that this selective resolution is there in the future.

Notes

Version

Published prerelease version: v1.1.0-next.6

Changelog

🎉 This release contains work from new contributors! 🎉

Thanks for all your work!

❤️ Daan Boer (@daanboer)

❤️ Adam Coster (@adam-coster)

❤️ Tom Mrazauskas (@mrazauskas)

❤️ Filipe Pomar (@filipomar)

❤️ null@baggoedw

❤️ Remi Cattiau (@loopingz)

❤️ Sergei Dyshel (@sergei-dyshel)

❤️ Hadrien Milano (@hmil)

🚀 Enhancement

🐛 Bug Fix

⚠️ Pushed to next

🔩 Dependency Updates

Authors: 12

@hydrosquall hydrosquall self-assigned this Sep 21, 2022
@hydrosquall
Copy link
Member Author

hydrosquall commented Sep 21, 2022 •
edited
Loading

I think this works- despite the error message in the CI, a package for this branch was published 5 minutes ago.

https://www.npmjs.com/package/ts-json-schema-generator/v/1.0.1--canary.858e8cf.0

The error message for that looks a lot like https://stackoverflow.com/a/55610612 , but I suggest we debug that issue separately. (Edit: it looks like that's already a known issue, see #1362 (comment) )

This was referenced Sep 21, 2022
Closed
Open
@domoritz domoritz merged commit 0932406 into next Sep 21, 2022
@domoritz domoritz deleted the cameron.yick/fix-ts-node-error branch September 21, 2022 02:35
@github-actions github-actions bot mentioned this pull request Sep 21, 2022
Merged
@github-actions
Copy link

🚀 PR was released in v1.1.0 🚀

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease labels Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hydrosquall hydrosquall

Labels
released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hydrosquall @domoritz