fix: Handle multiple sourceless nodes #1545
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @domoritz, it's me again 🤡👍
At #1386 I let a todo to resolve later because I didn't think that it would impact on anything.
ts-json-schema-generator/src/Utils/nodeKey.ts
Lines 38 to 40 in b428d2d
Seems out that we can have conflicts with sourceless nodes for objects with deep properties. And by conflicts I mean different types having the same ID, overriding each other when joining definitions.
This PR introduces the fix and a very deep test case for it.
P.S. Would you release as soon as you can? I have two a critical issue waiting for this 😁
Version
Published prerelease version:
v1.2.1-next.1
Changelog
🎉 This release contains work from a new contributor! 🎉
Thank you, Grant Dickinson (@grant-d), for all your work!
🐛 Bug Fix
🔩 Dependency Updates
Authors: 4