Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: required object annotation #1789

Merged
merged 3 commits into from
Oct 15, 2023
Merged

Conversation

georeith
Copy link
Contributor

@georeith georeith commented Oct 6, 2023

Adds the required property and some tests to ensure it works correctly with $data.

I couldn't see an existing way to make it exclusive to object types.

See: #1788

Version

Published prerelease version: v1.4.0-next.0

Changelog

🎉 This release contains work from a new contributor! 🎉

Thank you, null@georeith, for all your work!

🚀 Enhancement

🔩 Dependency Updates

Authors: 2

@@ -92,5 +92,6 @@
"debug": "node -r ts-node/register --inspect-brk ts-json-schema-generator.ts",
"run": "ts-node-transpile-only ts-json-schema-generator.ts",
"release": "yarn build && auto shipit"
}
},
"packageManager": "yarn@1.22.19"
Copy link
Contributor Author

@georeith georeith Oct 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this because my default package manager is yarn 3 but I use corepack to switch package manager in other repos. Without this yarn tried to migrate the repo to yarn 3.

I left it in because their may be others in my situation.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@domoritz domoritz enabled auto-merge (squash) October 15, 2023 13:43
@domoritz domoritz merged commit 47eb93c into vega:next Oct 15, 2023
4 checks passed
@github-actions github-actions bot mentioned this pull request Oct 16, 2023
@github-actions
Copy link

🚀 PR was released in v1.4.0 🚀

@github-actions github-actions bot added released This issue/pull request has been released. and removed prerelease labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants