Provide more type saftey for vega-lite fixme #1947
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A
FIXME
was introduced here that prevents zod'sz.infer
type helper from being processed properly. I don't have any knowledge of TypeScripts AST, but theif
statement that is throwing the error (see #758) assumes that iftype.typeArguments
is present, it can safelymap
overtype.typeArguments[0].types
. Instead of assuming this true, I added additional type checking soz.infer
doesn't fall into thisif
statement and attempt tomap
unless it is an array.Fixes
#758
Version
Published prerelease version:
v2.1.2-next.0
Changelog
🎉 This release contains work from a new contributor! 🎉
Thank you, Tim (@timothympace), for all your work!
🐛 Bug Fix
🔩 Dependency Updates
Authors: 2