Support tuple type narrowing, fix call expression parser #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, I have no more time to resolve these issues:
|
domoritz
approved these changes
Sep 15, 2020
package.json
Outdated
| @@ -51,6 +55,8 @@ | |||
| "eslint": "^7.8.1", | |||
| "eslint-config-prettier": "^6.11.0", | |||
| "eslint-plugin-prettier": "^3.1.4", | |||
| "fp-ts": "^2.8.2", | |||
There was a problem hiding this comment.
Let's not rely on specific third-party libraries for the tests and instead boil the test case down to a unit test.
| @@ -17,7 +16,7 @@ export class ArrayLiteralExpressionNodeParser implements SubNodeParser { | |||
| if (node.elements) { | |||
| const elements = node.elements.map((t) => this.childNodeParser.createType(t, context)).filter(notUndefined); | |||
|
|
|||
| return new ArrayType(new UnionType(elements)); | |||
| return new TupleType(elements); | |||
test/valid-data-third-party.test.ts
Outdated
| @@ -0,0 +1,5 @@ | |||
| import { assertValidSchema } from "./utils"; | |||
domoritz
changed the title
domoritz
approved these changes
Sep 16, 2020
| @@ -14,10 +11,19 @@ export class CallExpressionParser implements SubNodeParser { | |||
| } | |||
| public createType(node: ts.CallExpression, context: Context): BaseType { | |||
There was a problem hiding this comment.
Can you add a test that covers this code below?
| return new TupleType([ | ||
| new UnionType((type as any).typeArguments[0].types.map((t: any) => new LiteralType(t.value))), | ||
| ]); | ||
| node.arguments.forEach((arg) => { |
There was a problem hiding this comment.
Please use for (const arg of node.arguments) {}
| return node.kind === ts.SyntaxKind.PropertyAccessExpression; | ||
| } | ||
|
|
||
| public createType(node: ts.PropertyAccessExpression, context: Context): BaseType | undefined { |
There was a problem hiding this comment.
Please add a test that covers this case
|
@mooyoul These changes are great and I would love to merge them. Can you finish up the two small changes? |
|
Hmm, unfortunately, this change breaks const IDX = {
foo: 1,
bar: 1,
};
export const keys = Object.keys as <T>(o: T) => Extract<keyof T, string>[];
export const Foo = keys(IDX);
export type MyType = typeof Foo[number]; |
|
@mooyoul it would be awesome if you could help fix this case above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add PropertyAccessExpression support (w/ unit test)
Supports schema generation of below code:
Support type Narrowing of tuple type using array-like object condition
Supports schema generation of below code:
Use TupleType in ArrayLiteralExpression parser by default
Fix broken CallExpressionParser
Resolves issue with 3rd party type imports (e.g. io-ts)
Add integration test with 3rd party io-ts package
Related Issues