feat: correct monarchs.json and add source information #596
Conversation
|
D3 example: https://mbostock.github.io/protovis/ex/wheat-full.html Original image from Playfair: |
There was a problem hiding this comment.
- Having Elizabeth start earlier makes the Vega-Lite chart extend the domain. We should fix the domain before accepting this change. Similar with the end.
I suspect the data was made specifically for this chart so the start and end doesn't really matter. If we want to change the data, we should update the examples in Vega, Vega-Lite, and Altair before merging.
|
It's simple enough to avoid any breaking changes in any dependent visualizations by revising the SOURCES.md file to acknowledge that "the dataset contains two intentional inaccuracies to maintain compatibility with" Wheat and Wages. I didn't include links to the D3 or protovis examples but please feel free to do so if you'd like. |
| {"name":"James I","start":1603,"end":1625,"index":1}, | ||
| {"name":"Charles I","start":1625,"end":1649,"index":2}, | ||
| {"name":"Cromwell","start":1649,"end":1660,"commonwealth":true,"index":3}, | ||
| {"name":"Charles II","start":1660,"end":1685,"index":4}, | ||
| {"name":"James II","start":1685,"end":1689,"index":5}, | ||
| {"name":"James II","start":1685,"end":1688,"index":5}, | ||
| {"name":"W&M","start":1689,"end":1702,"index":6}, |
There was a problem hiding this comment.
https://www.hrp.org.uk/kensington-palace/history-and-stories/william-iii-and-mary-ii/#gs.e3lczb says
William III and Mary II were England’s first and only joint sovereigns, with Mary sharing equal status and power. William and Mary came to the throne after the "Glorious Revolution" of 1688 when Mary’s father, James II, was deposed for trying to enforce Catholic tolerance in England. The King and Queen ruled jointly from 1689 until Mary’s death aged 32 in 1694.
Is 1702 correct?
There was a problem hiding this comment.
While William & Mary's joint rule ended in 1694, William's solo reign continued until his death in 1702, when he was thrown from a horse and broke his collar bone. This is noted in the proposed SOURCES.md entry as follows:
William & Mary's Reign
The entry "W&M" represents the joint reign of William III and Mary II. While the dataset shows their reign as 1689-1702, the official Web site of the British royal family indicates that Mary II's reign ended in 1694, though William III continued to rule until 1702.
The dataset was created prior to the reign of Elizabeth II
Co-authored-by: Dominik Moritz <domoritz@gmail.com>
Resolves #595
Before approving, please review how the dataset corrections will alter the example visualization
Wheat and Wagesappearing in the Vega, Vega-Lite and Altair example galleries.Original from vega-lite gallery
Modified by hard-coding proposed changes