Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: correct monarchs.json and add source information #596

Merged
merged 4 commits into from
Sep 6, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions SOURCES.md
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,46 @@ Selected rail lines simplified from `tfl_lines.json` at https://github.com/oobri

## `monarchs.json`

A chronological list of English and British monarchs from Elizabeth I through George IV.
### Data Structure
Each entry includes:

- `name`: The ruler's name or identifier (e.g., "W&M" for William and Mary, "Cromwell" for the period of interregnum)
- `start`: The year their rule began.
- `end`: The year their rule ended
- `index`: A [zero-based sequential number](https://en.wikipedia.org/wiki/Zero-based_numbering) assigned to each entry, representing the chronological order of rulers
- `commonwealth`: A Boolean flag (true) for the period from 1649 to 1660. This field is omitted for all other entries.

### Known Inaccuracies and Special Notes

#### Start and end dates
The dataset contains two intentional inaccuracies to maintain compatibility with the [Wheat and Wages](https://vega.github.io/vega/examples/wheat-and-wages/) example visualization:
1. the start date for the reign of Elizabeth I is shown as 1565, instead of 1558;
2. the end date for the reign of George IV is shown as 1820, instead of 1830.

These discrepancies align the `monarchs.json` dataset with the start and end dates of the `wheat.json` dataset used i the visualization.

#### William & Mary's Reign
The entry "W&M" represents the joint reign of William III and Mary II. While the dataset shows their reign as 1689-1702, the official Web site of the British royal family indicates that Mary II's reign ended in 1694, though William III continued to rule until 1702.

#### Interregnum Period
The `commonwealth` field is used to flag the period from 1649 to 1660, which includes the Commonwealth of England, the Protectorate, and the period leading to the Restoration. While historically more accurate to call this the "interregnum," the field name of `commonwealth` from the original dataset is retained for backwards compatibility.

#### Recent updates

The dataset was revised in Aug. 2024 with the following corrections:

* Elizabeth I's name is updated to include the [regnal number](https://en.wikipedia.org/wiki/Regnal_number) "I"
* James II's reign now ends in 1688 (previously 1689)
dsmedia marked this conversation as resolved.
Show resolved Hide resolved


### Data Source and Licensing
Source data has been verified against the [kings & queens](https://www.royal.uk/kings-and-queens-1066
) and [interregnum](https://www.royal.uk/interregnum-1649-1660
) [official website of the British royal family](https://www.royal.uk) pages of the official Web site of the British royal family (retrieved in Aug. 2024). Content on the site is protected by Crown Copyright. Under the [UK Government Licensing Framework](https://www.nationalarchives.gov.uk/information-management/re-using-public-sector-information/uk-government-licensing-framework/crown-copyright/), most Crown copyright information is available under the [Open Government Licence v3.0](https://www.nationalarchives.gov.uk/doc/open-government-licence/version/3/).



## `movies.json`

The dataset has well known and intentionally included errors. This dataset is used for instructional purposes, including the need to reckon with dirty data.
Expand Down
4 changes: 2 additions & 2 deletions data/monarchs.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
{"name":"Charles I","start":1625,"end":1649,"index":2},
{"name":"Cromwell","start":1649,"end":1660,"commonwealth":true,"index":3},
{"name":"Charles II","start":1660,"end":1685,"index":4},
{"name":"James II","start":1685,"end":1689,"index":5},
{"name":"James II","start":1685,"end":1688,"index":5},
{"name":"W&M","start":1689,"end":1702,"index":6},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.hrp.org.uk/kensington-palace/history-and-stories/william-iii-and-mary-ii/#gs.e3lczb says

William III and Mary II were England’s first and only joint sovereigns, with Mary sharing equal status and power. William and Mary came to the throne after the "Glorious Revolution" of 1688 when Mary’s father, James II, was deposed for trying to enforce Catholic tolerance in England. The King and Queen ruled jointly from 1689 until Mary’s death aged 32 in 1694.

Is 1702 correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While William & Mary's joint rule ended in 1694, William's solo reign continued until his death in 1702, when he was thrown from a horse and broke his collar bone. This is noted in the proposed SOURCES.md entry as follows:

William & Mary's Reign

The entry "W&M" represents the joint reign of William III and Mary II. While the dataset shows their reign as 1689-1702, the official Web site of the British royal family indicates that Mary II's reign ended in 1694, though William III continued to rule until 1702.

{"name":"Anne","start":1702,"end":1714,"index":7},
{"name":"George I","start":1714,"end":1727,"index":8},
{"name":"George II","start":1727,"end":1760,"index":9},
{"name":"George III","start":1760,"end":1820,"index":10},
{"name":"George IV","start":1820,"end":1820,"index":11}
]
]