fix: unescape paths in binned timeunits

vega · Sep 12, 2023 · 34ecf2e · 34ecf2e
1 parent 76e5460
commit 34ecf2e
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/src/compile/data/timeunit.ts b/src/compile/data/timeunit.ts
@@ -170,7 +170,9 @@ export class TimeUnitNode extends DataFlowNode {
           as: [as, `${as}_end`]
         });
       } else if (f) {
-        const {field, timeUnit} = f;
+        const {field: escapedField, timeUnit} = f;
+        // since this is a expression, we want the unescaped field name
+        const field = escapedField.replaceAll('\\.', '.');
         const smallestUnit = getSmallestTimeUnitPart(timeUnit?.unit);
         const {part, step} = getDateTimePartAndStep(smallestUnit, timeUnit.step);
         transforms.push({

diff --git a/test/compile/data/timeunit.test.ts b/test/compile/data/timeunit.test.ts
@@ -70,6 +70,24 @@ describe('compile/data/timeunit', () => {
       ]);
     });
 
+    it('should return the proper field escaping with binnedyearmonth', () => {
+      const model = parseUnitModel({
+        data: {values: []},
+        mark: 'bar',
+        encoding: {
+          x: {field: 'a\\.b', type: 'temporal', timeUnit: 'binnedyearmonth'}
+        }
+      });
+
+      expect(assembleFromEncoding(model)).toEqual([
+        {
+          type: 'formula',
+          expr: `timeOffset('month', datum['a.b'], 1)`,
+          as: 'a.b_end'
+        }
+      ]);
+    });
+
     it('should return a unit offset transforms for text with bandPosition', () => {
       const model = parseUnitModel({
         data: {values: []},