Selection clearing should account for toggling.

vega · Apr 5, 2019 · 6b81dd2 · 6b81dd2
1 parent 519a2b6
commit 6b81dd2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/compile/selection/transforms/clear.ts b/src/compile/selection/transforms/clear.ts
@@ -2,6 +2,7 @@ import {Update} from 'vega';
 import {TUPLE} from '..';
 import {varName} from '../../../util';
 import inputBindings from './inputs';
+import toggle, {TOGGLE} from './toggle';
 import {TransformCompiler} from './transforms';
 
 const clear: TransformCompiler = {
@@ -41,8 +42,13 @@ const clear: TransformCompiler = {
         }
       });
     } else {
-      const tIdx = signals.findIndex(n => n.name === selCmpt.name + TUPLE);
+      let tIdx = signals.findIndex(n => n.name === selCmpt.name + TUPLE);
       addClear(tIdx, 'null');
+
+      if (toggle.has(selCmpt)) {
+        tIdx = signals.findIndex(n => n.name === selCmpt.name + TOGGLE);
+        addClear(tIdx, 'false');
+      }
     }
 
     return signals;

diff --git a/src/compile/selection/transforms/toggle.ts b/src/compile/selection/transforms/toggle.ts
@@ -1,7 +1,7 @@
 import {TUPLE, unitName} from '..';
 import {TransformCompiler} from './transforms';
 
-const TOGGLE = '_toggle';
+export const TOGGLE = '_toggle';
 
 const toggle: TransformCompiler = {
   has: selCmpt => {