fix: allow setting width/height in repeated layers (#8723)

vega · Mar 6, 2023 · 9e26410 · 9e26410
1 parent 36a4480
commit 9e26410
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 4 deletions.
diff --git a/build/vega-lite-schema.json b/build/vega-lite-schema.json
@@ -12467,7 +12467,7 @@
               "$ref": "#/definitions/LayerSpec"
             },
             {
-              "$ref": "#/definitions/UnitSpec"
+              "$ref": "#/definitions/UnitSpecWithFrame"
             }
           ],
           "description": "A specification of the view that gets repeated."
@@ -29223,7 +29223,7 @@
                   "$ref": "#/definitions/LayerSpec"
                 },
                 {
-                  "$ref": "#/definitions/UnitSpec"
+                  "$ref": "#/definitions/UnitSpecWithFrame"
                 }
               ],
               "description": "A specification of the view that gets repeated."

diff --git a/examples/specs/repeat_layer_size.json b/examples/specs/repeat_layer_size.json
@@ -0,0 +1,30 @@
+{
+  "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
+  "data": {
+    "url": "data/movies.json"
+  },
+  "repeat": {
+    "layer": ["US Gross", "Worldwide Gross"]
+  },
+  "spec": {
+    "width": 200,
+    "mark": "line",
+    "encoding": {
+      "x": {
+        "bin": true,
+        "field": "IMDB Rating",
+        "type": "quantitative"
+      },
+      "y": {
+        "aggregate": "mean",
+        "field": {"repeat": "layer"},
+        "type": "quantitative",
+        "title": "Mean of US and Worldwide Gross"
+      },
+      "color": {
+        "datum": {"repeat": "layer"},
+        "type": "nominal"
+      }
+    }
+  }
+}
diff --git a/src/spec/repeat.ts b/src/spec/repeat.ts
@@ -2,7 +2,7 @@ import {isArray} from 'vega-util';
 import {LayerSpec, NonNormalizedSpec} from '.';
 import {Field} from '../channeldef';
 import {BaseSpec, GenericCompositionLayoutWithColumns, ResolveMixins} from './base';
-import {UnitSpec} from './unit';
+import {UnitSpecWithFrame} from './unit';
 
 export interface RepeatMapping {
   /**
@@ -53,7 +53,7 @@ export interface LayerRepeatSpec extends BaseSpec, GenericCompositionLayoutWithC
   /**
    * A specification of the view that gets repeated.
    */
-  spec: LayerSpec<Field> | UnitSpec<Field>;
+  spec: LayerSpec<Field> | UnitSpecWithFrame<Field>;
 }
 
 export function isRepeatSpec(spec: BaseSpec): spec is RepeatSpec {