Skip to content

Commit

Permalink
fix: move name from layer chart to one of the inside layers (#8662)
Browse files Browse the repository at this point in the history
* Move name from layer chart to one of the inside layers

* chore: update TOC [CI]

* chore: update TOC [CI]

---------

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Co-authored-by: Dominik Moritz <domoritz@gmail.com>
  • Loading branch information
3 people authored Feb 13, 2023
1 parent 575f82d commit d99f614
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/normalize/pathoverlay.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export class PathOverlayNormalizer implements NonFacetUnitNormalizer<UnitSpecWit

public run(spec: UnitSpecWithPathOverlay, normParams: NormalizerParams, normalize: NormalizeLayerOrUnit) {
const {config} = normParams;
const {params, projection, mark, encoding: e, ...outerSpec} = spec;
const {params, projection, mark, name, encoding: e, ...outerSpec} = spec;

// Need to call normalizeEncoding because we need the inferred types to correctly determine stack
const encoding = normalizeEncoding(e, config);
Expand All @@ -113,6 +113,7 @@ export class PathOverlayNormalizer implements NonFacetUnitNormalizer<UnitSpecWit

const layer: NormalizedUnitSpec[] = [
{
name,
...(params ? {params} : {}),
mark: dropLineAndPoint({
// TODO: extract this 0.7 to be shared with default opacity for point/tick/...
Expand Down

0 comments on commit d99f614

Please sign in to comment.