Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove incorrect stack transform from charts with one linear Q-axis one non-linear Q-axis. #8871

Merged
merged 5 commits into from
Apr 28, 2023

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Apr 27, 2023

Remove incorrect stack transform from charts with one linear Q-axis one non-linear Q-axis.

@kanitw kanitw marked this pull request as ready for review April 27, 2023 23:28
@@ -104,15 +104,6 @@ function potentialStackedChannel(
// if there is no explicit stacking, only apply stack if there is only one aggregate for x or y
if (xAggregate !== yAggregate) {
return xAggregate ? x : y;
} else {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic was just wrong. Instead, we should rely on the orient logic below.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these two images supposed to be before and after? I don't see any changes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a new spec so there are new images.

Copy link
Member Author

@kanitw kanitw Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZacharyBys If you see the 4th (generated commits), you can see that the actual code changes in the 3rd commit fixes the problem.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Member

@domoritz domoritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There is a failing test for bar_q_qpow.vl.json, though.

@kanitw kanitw enabled auto-merge (squash) April 28, 2023 22:03
@kanitw kanitw merged commit f4d928a into main Apr 28, 2023
@kanitw kanitw deleted the kw/8870-stack-qpow branch April 28, 2023 22:07
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
…xis one non-linear Q-axis. (vega#8871)

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants