fix: remove incorrect stack transform from charts with one linear Q-axis one non-linear Q-axis. #8871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
force-pushed
the
kw/8870-stack-qpow
branch
from
2ec1077
to
0de5218
Compare
kanitw
commented
Apr 27, 2023
| @@ -104,15 +104,6 @@ function potentialStackedChannel( | |||
| // if there is no explicit stacking, only apply stack if there is only one aggregate for x or y | |||
| if (xAggregate !== yAggregate) { | |||
| return xAggregate ? x : y; | |||
| } else { | |||
There was a problem hiding this comment.
This logic was just wrong. Instead, we should rely on the orient logic below.
ZacharyBys
approved these changes
Apr 28, 2023
ZacharyBys
reviewed
Apr 28, 2023
examples/compiled/bar_q_qpow.png
Outdated
There was a problem hiding this comment.
Are these two images supposed to be before and after? I don't see any changes
There was a problem hiding this comment.
There is a new spec so there are new images.
There was a problem hiding this comment.
@ZacharyBys If you see the 4th (generated commits), you can see that the actual code changes in the 3rd commit fixes the problem.
domoritz
approved these changes
Apr 28, 2023
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
…xis one non-linear Q-axis. (vega#8871) Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove incorrect stack transform from charts with one linear Q-axis one non-linear Q-axis.