Should Vega-lite always include color for invalid by default? #9351
Labels
Milestone
Comments
3 tasks
kanitw
added a commit
that referenced
this issue
May 20, 2024
…valid data (e.g., nulls, NaNs) (#9342) - Add more spec options for handling invalid data - extend `mark.invalid` - add new `config.scale.invalid` - See [docs's pdf file from invalid.md](https://github.com/vega/vega-lite/files/15329038/Modes.for.Handling.Invalid.Data._.Vega-Lite.pdf) or the actual doc for explanation of the behavior. (Given the complexity of the PR, reviewers should check out the branch and test the spec locally.) refactor: - Adjust how we generate rules for invalid data to handle these options, per channel type. - data's invalid filter - `defined` encoding (for breaking paths) - Make wrapCondition accept invalidValueRef for "include" mode. - Remove the hidden/screen "hide" mode for invalid data (Given this is a hidden feature, it's not a breaking change.)## PR Description bug fixes: - fix #8254 -- correctly place invalid point as zero, when included. Known issues / Follow up items: - Tooltip doesn't show null correctly (#6417) -- I'll fix this separately in a follow up PR - Should Vega-lite always include color for invalid by default? (#9351) ## Checklist Tests: - [x] Integration tests -- added a bunch of examples - [x] Unit tests (in progress) -- I'll re-review the code and add more unit tests. Docs: - [x] Has documentation under `site/docs/` + examples. --------- Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
should we have default
config.scale.invalid.colorbased on #9342?The text was updated successfully, but these errors were encountered: