Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tick disrespects timeUnit for its width #9414

Closed
kanitw opened this issue Aug 27, 2024 · 1 comment
Closed

Tick disrespects timeUnit for its width #9414

kanitw opened this issue Aug 27, 2024 · 1 comment
Labels

Comments

@kanitw
Copy link
Member

kanitw commented Aug 27, 2024

{
  "$schema": "https://vega.github.io/schema/vega-lite/v5.json",
  "description": "Google's stock price over time.",
  "data": {"url": "data/stocks.csv"},
  "transform": [{"filter": "datum.symbol==='GOOG'"}],
  "mark": "bar",
  "encoding": {
    "x": {"timeUnit": "year", "field": "date", "type": "temporal"},
    "y": {"aggregate": "sum", "field": "price", "type": "quantitative"}
  }
}
image

whereas a similar bar would respect:

image
@kanitw
Copy link
Member Author

kanitw commented Aug 27, 2024

will be fixed in #9415

@kanitw kanitw closed this as completed Aug 27, 2024
kanitw added a commit that referenced this issue Aug 28, 2024
…nd (#9415)

## PR Description

Make ticks respect bin/timeUnit bands and custom band (by calling
`rectPosition()`, just like rect and bar marks)

See the examples added as a proof for fixing.

---------

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant