TS 2.9 follow up #3839
Merged
TS 2.9 follow up #3839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
force-pushed
the
dom/ts2.9-follow-up
branch
3 times, most recently
from
37c28d7 to
faf34cb
Compare
domoritz
force-pushed
the
dom/ts2.9-follow-up
branch
2 times, most recently
from
0a4ae33 to
440a25e
Compare
|
I had another issue upgrading to vega-lite 2.5.1 that I thought was related to the ts 2.9 upgrade, but decided it really was another issue: #3855 |
domoritz
force-pushed
the
dom/ts2.9-follow-up
branch
3 times, most recently
from
36fbfe0 to
cb90ea8
Compare
|
This change simplifies the package.json and also improves our sourcemaps. |
domoritz
force-pushed
the
dom/ts2.9-follow-up
branch
from
cb90ea8 to
6373e23
Compare
domoritz
commented
Jun 15, 2018
| @@ -45,7 +45,7 @@ | |||
| "renameschema": "scripts/rename-schema.sh", | |||
| "presite": "npm run prebuild && npm run data && npm run build:site && npm run build:toc && npm run build:versions && scripts/create-example-pages", | |||
| "site": "bundle exec jekyll serve --incremental", | |||
| "lint": "tslint -p .", | |||
| "lint": "tslint -p . -e 'package.json'", | |||
There was a problem hiding this comment.
This is to get around a bug in tslint.
|
Ready @kanitw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires microsoft/TypeScript/issues/24588 and microsoft/TypeScript#24546
Follow up for #3836