Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support repeat layer #6142

Merged
merged 5 commits into from
Mar 23, 2020
Merged

feat: support repeat layer #6142

merged 5 commits into from
Mar 23, 2020

Conversation

kanitw
Copy link
Member

@kanitw kanitw commented Mar 22, 2020 •
edited
Loading

Merge #6141 first

Implementation for #1274

@kanitw kanitw mentioned this pull request Mar 22, 2020
Closed
@kanitw kanitw requested a review from domoritz March 23, 2020 05:10
domoritz
domoritz approved these changes Mar 23, 2020
View reviewed changes
src/spec/repeat.ts Outdated Show resolved Hide resolved
kanitw and others added 3 commits March 23, 2020 12:03
@kanitw
feat: support repeat layer
3b28999 
part of #1274

Note that repeat layer isn't very useful yet until we have `datum` support (#1601)
@kanitw
chore: update schema [CI]
00377c2
@kanitw
chore: update examples [CI]
7e0ca17
@kanitw kanitw merged commit 43ec4a2 into master Mar 23, 2020
@kanitw kanitw deleted the kw/repeat-layer branch March 23, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@domoritz domoritz domoritz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanitw @domoritz