Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update selection toggle to conform with point selection behavior #8270

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

arvind
Copy link
Member

@arvind arvind commented Jul 8, 2022

When single and multi selections were merged into a point selection,
it no longer became possible to disabling toggling to yield only
multi-point insertion (as was possible with the old multi selection).

Partially addresses #8066.

📦 Published PR as canary version: 5.3.1--canary.8270.ef8c0b6.0

✨ Test out this PR locally via:

npm install vega-lite@5.3.1--canary.8270.ef8c0b6.0
# or 
yarn add vega-lite@5.3.1--canary.8270.ef8c0b6.0

When single and multi selections were merged into a point selection,
it no longer became possible to disabling toggling to yield only
multi-point insertion (as was possible with the old multi selection).
@arvind arvind requested a review from a team July 8, 2022 16:33
@kanitw kanitw merged commit 57a6be4 into next Aug 17, 2022
@kanitw kanitw deleted the as/toggleDocs branch August 17, 2022 03:55
@vega-org-bot vega-org-bot mentioned this pull request Aug 18, 2022
@vega-org-bot vega-org-bot mentioned this pull request Oct 10, 2022
6 tasks
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
vega#8270)

Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants