feat: Allow config to set default scale.zero per marktype #8354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhoonkim
force-pushed
the
yh/config-zero
branch
4 times, most recently
from
a43105c
to
cf03378
Compare
kanitw
requested changes
Aug 15, 2022
| @@ -60,7 +60,11 @@ | |||
| "domain": {"data": "data_0", "fields": ["start", "end"]}, | |||
| "range": [0, {"signal": "width"}], | |||
| "nice": true, | |||
| <<<<<<< Updated upstream | |||
There was a problem hiding this comment.
I know you fix this later, but you may want to leverage interactive rebase to clean this up in the future, so reviewers see less noise as they step through commits ;)
src/compile/scale/properties.ts
Outdated
|
|
||
| // 1) using quantitative field with size | ||
| // While this can be either ratio or interval fields, our assumption is that | ||
| // ratio are more common. However, if the scaleType is discretizing scale, we want to return | ||
| // false so that range doesn't start at zero | ||
| if (channel === 'size' && fieldDef.type === 'quantitative' && !isContinuousToDiscrete(scaleType)) { | ||
| return true; | ||
| return defaultZero; |
There was a problem hiding this comment.
I wonder if config.zero also shouldn't affect size scale (since quantitative size scale are probably should scale down to zero).
src/compile/scale/properties.ts
Outdated
| @@ -120,7 +120,8 @@ function parseUnitScaleProperty(model: UnitModel, property: Exclude<keyof (Scale | |||
| domainMax: specifiedScale.domainMax, | |||
| markDef, | |||
| config, | |||
| hasNestedOffsetScale: channelHasNestedOffsetScale(encoding, channel) | |||
| hasNestedOffsetScale: channelHasNestedOffsetScale(encoding, channel), | |||
| hasRangeChannels: encodingHasRangeChannels(encoding) | |||
There was a problem hiding this comment.
The fact that encodingHasRangeChannels(encoding) doesn't take in channel seems alarming to me.
Basically, Y2 shouldn't affect x-scale's zero.
I think you should
- undo adding
encodingHasRangeChannels - rename
hasRangeChannelstohasRangeChanneland just check if there is x2 for x or y2 for x. (And maybe radius2 for radius.)
site/docs/encoding/scale.md
Outdated
| @@ -444,7 +444,7 @@ To provide themes for all scales, the scale config (`config: {scale: {...}}`) ca | |||
|
|
|||
| #### Padding | |||
|
|
|||
| {% include table.html props="bandPaddingInner,barBandPaddingInner,rectBandPaddingInner,bandWithNestedOffsetPaddingInner,offsetBandPaddingInner,bandPaddingOuter,bandWithNestedOffsetPaddingOuter,offsetBandPaddingOuter,continuousPadding,pointPadding" source="ScaleConfig" %} | |||
| {% include table.html props="bandPaddingInner,barBandPaddingInner,rectBandPaddingInner,bandWithNestedOffsetPaddingInner,offsetBandPaddingInner,bandPaddingOuter,bandWithNestedOffsetPaddingOuter,offsetBandPaddingOuter,continuousPadding,pointPadding,zero" source="ScaleConfig" %} | |||
There was a problem hiding this comment.
Why is zero added to the padding table? This seems wrong?
src/scale.ts
Outdated
| @@ -415,6 +415,14 @@ export interface ScaleConfig<ES extends ExprRef | SignalRef> { | |||
| * Reverse x-scale by default (useful for right-to-left charts). | |||
| */ | |||
| xReverse?: boolean | ES; | |||
|
|
|||
| /** | |||
| * Override the default `scale.zero` for [`continuous`](https://vega.github.io/vega-lite/docs/scale.html#continuous) scale except for non-ranged bar or area charts. | |||
There was a problem hiding this comment.
except for non-ranged bar or area charts.
If you agree with the other comment to always do "zero" for size scale.
except for (1) x/y-scales of non-ranged bar or area charts and (2) size scales.
src/compile/scale/properties.ts
Outdated
| @@ -418,18 +422,21 @@ export function zero( | |||
| } | |||
| } | |||
|
|
|||
| // If there is no custom domain, return true only for the following cases: | |||
| const defaultZero = scaleConfig?.zero === undefined ? true : scaleConfig?.zero; | |||
There was a problem hiding this comment.
Instead of adding this line, probably cleaner to add zero: true to defaultScaleConfig.
yhoonkim
force-pushed
the
yh/config-zero
branch
from
aa593a8
to
f384cc4
Compare
- Undo encodingHasRangeChannels - Set `true` for continuous size scale regardless to config - Fix doc
yhoonkim
force-pushed
the
yh/config-zero
branch
from
f384cc4
to
2c8cc57
Compare
kanitw
approved these changes
Aug 16, 2022
Closed
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
* Add examples * chore: update examples [CI] * Add config.scale.zero * chore: update examples [CI] * update doc * Minor refactor: - Undo encodingHasRangeChannels - Set `true` for continuous size scale regardless to config - Fix doc * Update the doc and fix the typo Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#8324 Allow config to set default scale.zero per marktype.
config.scale.zero===false, zero is false as default except for the non-ranged bar/area chart.📦 Published PR as canary version:
5.5.1--canary.8354.6729853.0✨ Test out this PR locally via:
npm install vega-lite@5.5.1--canary.8354.6729853.0 # or yarn add vega-lite@5.5.1--canary.8354.6729853.0Version
Published prerelease version:
v5.6.0-next.0Changelog
🚀 Enhancement
Authors: 2