fix(#8327): Boxplot set null quantitative to 0 #8409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhoonkim
changed the title
yhoonkim
commented
Sep 12, 2022
site/_data/versions.yml
Outdated
| vega: 5.22.1 | ||
| vega-lite: 5.5.0 | ||
| vega-embed: 6.21.0 | ||
| vega-tooltip: 0.28.0 |
There was a problem hiding this comment.
I'm not sure if I should include this file.
There was a problem hiding this comment.
yeah, please remove it. It doesn't seem relevant to this PR.
kanitw
approved these changes
Sep 12, 2022
src/compositemark/boxplot.ts
Outdated
| @@ -102,6 +103,8 @@ export function normalizeBoxPlot( | |||
| config | |||
| ); | |||
|
|
|||
| const invalid = markDef.invalid || null; //|| null to respect the existed default behavior | |||
There was a problem hiding this comment.
Let's remove || null; //|| null to respect the existed default behavior
since the doc has been saying that filter is the default (for all marks).
So the existing behavior to include null by default was a bug.
src/mark.ts
Outdated
| @@ -75,7 +75,16 @@ export interface TooltipContent { | |||
| /** @hidden */ | |||
| export type Hide = 'hide'; | |||
|
|
|||
| export interface VLOnlyMarkConfig<ES extends ExprRef | SignalRef> extends ColorMixins<ES> { | |||
| export interface MarkInvalid { | |||
There was a problem hiding this comment.
For consistency, please rename to MarkInvalidMixins.
site/_data/versions.yml
Outdated
| vega: 5.22.1 | ||
| vega-lite: 5.5.0 | ||
| vega-embed: 6.21.0 | ||
| vega-tooltip: 0.28.0 |
There was a problem hiding this comment.
yeah, please remove it. It doesn't seem relevant to this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #8327
📦 Published PR as canary version:
5.5.1--canary.8409.94b06f4.0✨ Test out this PR locally via:
npm install vega-lite@5.5.1--canary.8409.94b06f4.0 # or yarn add vega-lite@5.5.1--canary.8409.94b06f4.0