fix: Remove x2/y2 channels for overlaying line and point #8472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanitw
reviewed
Oct 11, 2022
src/normalize/pathoverlay.ts
Outdated
| @@ -151,7 +151,7 @@ export class PathOverlayNormalizer implements NonFacetUnitNormalizer<UnitSpecWit | |||
| ...pick(markDef, ['clip', 'interpolate', 'tension', 'tooltip']), | |||
| ...lineOverlay | |||
| }, | |||
| encoding: overlayEncoding | |||
| encoding: omit(overlayEncoding, ['y2', 'x2']) | |||
There was a problem hiding this comment.
(minor) Probably better to do this above once
overlayEncoding = omit(overlayEncoding , ['y2', 'x2']));
above add comment to explain why y2/x2 shouldn't be a part of "overlayEncoding". (Describe an example that we need to trigger this case.)
kanitw
approved these changes
Oct 11, 2022
|
🚀 PR was released in |
vega-org-bot
added
released
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
* add example * Remove y2/x2 channel for overlaying lines and points * Add comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the overlaying line and point layers not to have x2 and y2 which is either not necessary or can cause unwanted lines.
📦 Published PR as canary version:
5.5.1--canary.8472.2a80c42.0✨ Test out this PR locally via:
npm install vega-lite@5.5.1--canary.8472.2a80c42.0 # or yarn add vega-lite@5.5.1--canary.8472.2a80c42.0