Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update vega and other dependencies #8857

Merged
merged 5 commits into from
Apr 27, 2023
Merged

feat: update vega and other dependencies #8857

merged 5 commits into from
Apr 27, 2023

Conversation

domoritz
Copy link
Member

@domoritz domoritz commented Apr 21, 2023

Fixes #8841

@domoritz
Copy link
Member Author

domoritz commented Apr 21, 2023

Ah, this doesn't work because of vega/ts-json-schema-generator#1610 which is caused by an update in the types. I looked at this a few weeks ago and it would take me a few more hours to fix (@lsh helped me look at it as well). I think our options are to revert the scale and Vega updates or to wait for me to get a few hours to fix this). I can prioritize the fix this weekend.

@domoritz
Copy link
Member Author

Depends on vega/vega#3735

@kanitw kanitw merged commit 6a6da3b into main Apr 27, 2023
@kanitw kanitw deleted the dom/versions branch April 27, 2023 22:01
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
Co-authored-by: GitHub Actions Bot <vega-actions-bot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website shows broken example
2 participants