feat: switch from clone to built in structured clone #9068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
domoritz
commented
Aug 23, 2023
•
domoritz
commented
- update jest
- remove dependencies (no more commonjs deps)
Also fix issues around structured clone
lsh
approved these changes
Aug 30, 2023
# Conflicts: # yarn.lock
|
Why is this a feat? |
|
It gets rid of a dependency and should enable esm support (which I haven't tested yet so I didn't highlight it here). |
alliefeldman
pushed a commit
to alliefeldman/vega-lite
that referenced
this pull request
Oct 2, 2023
BradyJ27
pushed a commit
to BradyJ27/vega-lite
that referenced
this pull request
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.