Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: lint pull request messages #9099

Merged
merged 1 commit into from
Sep 20, 2023
Merged

ci: lint pull request messages #9099

merged 1 commit into from
Sep 20, 2023

Conversation

domoritz
Copy link
Member

@jonmmease
Copy link
Contributor

This looks good, but I don't see GitHub Actions actually running it

@domoritz
Copy link
Member Author

I think it only runs after this is merged which makes it hard to test admittedly.

jonmmease
jonmmease approved these changes Sep 20, 2023
View reviewed changes
Copy link
Contributor

@jonmmease jonmmease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give it a try

@domoritz domoritz merged commit 86025d9 into main Sep 20, 2023
10 checks passed
@domoritz domoritz deleted the dom/commit-lint branch September 20, 2023 00:14
alliefeldman pushed a commit to alliefeldman/vega-lite that referenced this pull request Oct 2, 2023
@domoritz @alliefeldman
ci: lint pull request messages (vega#9099)
f139e6f
BradyJ27 pushed a commit to BradyJ27/vega-lite that referenced this pull request Oct 19, 2023
@domoritz @BradyJ27
ci: lint pull request messages (vega#9099)
0be440e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonmmease jonmmease jonmmease approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domoritz @jonmmease