Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add filter and sort support for tooltips #9148

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

feat: add filter and sort support for tooltips #9148

wants to merge 9 commits into from

Commits on Oct 22, 2023

  1. Add filter and sort support for vega tooltip.

    @sfc-gh-cheliu
    sfc-gh-cheliu committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    0d713ad View commit details
    Browse the repository at this point in the history

  2. Remove outdated and unused schema.

    @sfc-gh-cheliu
    sfc-gh-cheliu committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    a310ffc View commit details
    Browse the repository at this point in the history

  3. Remove unused properties.

    @sfc-gh-cheliu
    sfc-gh-cheliu committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    75f7248 View commit details
    Browse the repository at this point in the history

  4. Remove outdated interface.

    @sfc-gh-cheliu
    sfc-gh-cheliu committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    e35f83e View commit details
    Browse the repository at this point in the history

  5. Remove some print statements.

    @sfc-gh-cheliu
    sfc-gh-cheliu committed Oct 22, 2023
    Configuration menu
    Copy the full SHA
    af04935 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Make 'sort' parameter appear in a higher level, as part of the encoding.

    @sfc-gh-cheliu
    sfc-gh-cheliu committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    c4a954d View commit details
    Browse the repository at this point in the history

  2. Make sort_tooltip value to be only ascending or decending, otherwise … 

    …fire a schema validation warning.
    @sfc-gh-cheliu
    sfc-gh-cheliu committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    935d421 View commit details
    Browse the repository at this point in the history

  3. Make TooltipFilter robust as well.

    @sfc-gh-cheliu
    sfc-gh-cheliu committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    79c01d7 View commit details
    Browse the repository at this point in the history

  4. Add more description for the new parameters in the schema.

    @sfc-gh-cheliu
    sfc-gh-cheliu committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    70e2f94 View commit details
    Browse the repository at this point in the history