Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: for interactive charts, changed cursor to pointer (also updated tests) #9328

Closed
wants to merge 4 commits into from
Closed

feat: for interactive charts, changed cursor to pointer (also updated tests) #9328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa09820
For interactive charts, changed cursor to pointer (also updated tests)
JessamineQ Apr 11, 2024
622762d
Merge branch 'main' into pr/JessamineQ/9305
domoritz May 1, 2024
61b48fb
chore: update examples [CI]
May 1, 2024
4d37e17
Remove superfluous cursor.
domoritz May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/compiled/airport_connections.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@
"fill": {"value": "#ddd"},
"stroke": {"value": "#fff"},
"strokeWidth": {"value": 1},
"cursor": {"value": "pointer"},
"ariaRoleDescription": {"value": "geoshape"}
}
},
Expand All @@ -199,6 +200,7 @@
"encode": {
"update": {
"opacity": {"value": 0.35},
"cursor": {"value": "pointer"},
"stroke": {"value": "#000"},
"description": {
"signal": "\"longitude: \" + (format(datum[\"longitude\"], \"\")) + \"; lon2: \" + (format(datum[\"lon2\"], \"\")) + \"; latitude: \" + (format(datum[\"latitude\"], \"\")) + \"; lat2: \" + (format(datum[\"lat2\"], \"\"))"
Expand All @@ -220,6 +222,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "circle"},
"description": {
Expand Down
2 changes: 2 additions & 0 deletions examples/compiled/bar_count_minimap.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@
"from": {"data": "data_1"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down Expand Up @@ -354,6 +355,7 @@
"from": {"data": "data_2"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down
4 changes: 4 additions & 0 deletions examples/compiled/brush_table.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": {"value": "transparent"},
"stroke": [
{
Expand Down Expand Up @@ -531,6 +532,7 @@
"from": {"data": "data_1"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "black"},
"description": {
"signal": "\"row_number: \" + (isValid(datum[\"row_number\"]) ? datum[\"row_number\"] : \"\"+datum[\"row_number\"]) + \"; Horsepower: \" + (isValid(datum[\"Horsepower\"]) ? datum[\"Horsepower\"] : \"\"+datum[\"Horsepower\"])"
Expand Down Expand Up @@ -567,6 +569,7 @@
"from": {"data": "data_1"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "black"},
"description": {
"signal": "\"row_number: \" + (isValid(datum[\"row_number\"]) ? datum[\"row_number\"] : \"\"+datum[\"row_number\"]) + \"; Miles_per_Gallon: \" + (isValid(datum[\"Miles_per_Gallon\"]) ? datum[\"Miles_per_Gallon\"] : \"\"+datum[\"Miles_per_Gallon\"])"
Expand Down Expand Up @@ -603,6 +606,7 @@
"from": {"data": "data_1"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "black"},
"description": {
"signal": "\"row_number: \" + (isValid(datum[\"row_number\"]) ? datum[\"row_number\"] : \"\"+datum[\"row_number\"]) + \"; Origin: \" + (isValid(datum[\"Origin\"]) ? datum[\"Origin\"] : \"\"+datum[\"Origin\"])"
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/circle_bubble_health_income.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": {"value": "#000"},
"ariaRoleDescription": {"value": "circle"},
"description": {
Expand Down
3 changes: 3 additions & 0 deletions examples/compiled/concat_bar_layer_circle.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@
"from": {"data": "data_2"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"opacity": {"value": 0.4},
"ariaRoleDescription": {"value": "circle"},
Expand All @@ -173,6 +174,7 @@
"from": {"data": "data_1"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "circle"},
"description": {
Expand Down Expand Up @@ -303,6 +305,7 @@
"from": {"data": "data_3"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": [
{
"test": "!length(data(\"pts_store\")) || vlSelectionTest(\"pts_store\", datum)",
Expand Down
2 changes: 2 additions & 0 deletions examples/compiled/concat_hover.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": {"value": "transparent"},
"stroke": [
{
Expand Down Expand Up @@ -239,6 +240,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": {"value": "transparent"},
"stroke": [
{
Expand Down
4 changes: 4 additions & 0 deletions examples/compiled/concat_hover_filter.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": {"value": "transparent"},
"stroke": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "point"},
Expand All @@ -161,6 +162,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": {"value": "transparent"},
"stroke": {"value": "goldenrod"},
"ariaRoleDescription": {"value": "point"},
Expand Down Expand Up @@ -282,6 +284,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": {"value": "transparent"},
"stroke": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "point"},
Expand All @@ -302,6 +305,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": {"value": "transparent"},
"stroke": {"value": "goldenrod"},
"ariaRoleDescription": {"value": "point"},
Expand Down
2 changes: 2 additions & 0 deletions examples/compiled/dynamic_color_legend.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": {"value": "transparent"},
"stroke": [
{
Expand Down Expand Up @@ -497,6 +498,7 @@
"from": {"data": "data_1"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": [
{
"test": "!length(data(\"click_store\")) || vlSelectionTest(\"click_store\", datum)",
Expand Down
2 changes: 2 additions & 0 deletions examples/compiled/interactive_1d_geo_brush.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@
"update": {
"fill": {"value": "lightgray"},
"stroke": {"value": "white"},
"cursor": {"value": "pointer"},
"ariaRoleDescription": {"value": "geoshape"}
}
},
Expand All @@ -283,6 +284,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": [
{
"test": "length(data(\"brush_store\")) && vlSelectionIdTest(\"brush_store\", datum)",
Expand Down
6 changes: 6 additions & 0 deletions examples/compiled/interactive_airport_crossfilter.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,6 +482,7 @@
"update": {
"fill": {"value": "lightgray"},
"stroke": {"value": "white"},
"cursor": {"value": "pointer"},
"ariaRoleDescription": {"value": "geoshape"}
}
},
Expand All @@ -496,6 +497,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": [
{
"test": "length(data(\"brush_store\")) && vlSelectionIdTest(\"brush_store\", datum)",
Expand Down Expand Up @@ -588,6 +590,7 @@
"from": {"data": "data_4"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "steelblue"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down Expand Up @@ -623,6 +626,7 @@
"from": {"data": "data_3"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "goldenrod"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down Expand Up @@ -706,6 +710,7 @@
"from": {"data": "data_5"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "steelblue"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down Expand Up @@ -738,6 +743,7 @@
"from": {"data": "data_2"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "goldenrod"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down
2 changes: 2 additions & 0 deletions examples/compiled/interactive_area_brush.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@
"encode": {
"update": {
"orient": {"value": "vertical"},
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"description": {
"signal": "\"date (year-month): \" + (timeFormat(datum[\"yearmonth_date\"], timeUnitSpecifier([\"year\",\"month\"], {\"year-month\":\"%b %Y \",\"year-month-date\":\"%b %d, %Y \"}))) + \"; Sum of count: \" + (format(datum[\"sum_count\"], \"\"))"
Expand All @@ -300,6 +301,7 @@
"encode": {
"update": {
"orient": {"value": "vertical"},
"cursor": {"value": "pointer"},
"fill": {"value": "goldenrod"},
"description": {
"signal": "\"date (year-month): \" + (timeFormat(datum[\"yearmonth_date\"], timeUnitSpecifier([\"year\",\"month\"], {\"year-month\":\"%b %Y \",\"year-month-date\":\"%b %d, %Y \"}))) + \"; Sum of count: \" + (format(datum[\"sum_count\"], \"\"))"
Expand Down
2 changes: 2 additions & 0 deletions examples/compiled/interactive_bin_extent.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,6 +329,7 @@
"from": {"data": "data_1"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down Expand Up @@ -455,6 +456,7 @@
"from": {"data": "data_0"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down
2 changes: 2 additions & 0 deletions examples/compiled/interactive_bin_extent_bottom.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,7 @@
"from": {"data": "data_1"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down Expand Up @@ -411,6 +412,7 @@
"from": {"data": "data_0"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down
1 change: 1 addition & 0 deletions examples/compiled/interactive_brush.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,6 +322,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": {"value": "transparent"},
"stroke": [
{
Expand Down
3 changes: 3 additions & 0 deletions examples/compiled/interactive_concat_layer.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@
"from": {"data": "data_2"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"scale": "color", "field": "__count"},
"description": {
"signal": "\"IMDB Rating (binned): \" + (!isValid(datum[\"bin_maxbins_10_IMDB Rating\"]) || !isFinite(+datum[\"bin_maxbins_10_IMDB Rating\"]) ? \"null\" : format(datum[\"bin_maxbins_10_IMDB Rating\"], \"\") + \" – \" + format(datum[\"bin_maxbins_10_IMDB Rating_end\"], \"\")) + \"; Rotten Tomatoes Rating (binned): \" + (!isValid(datum[\"bin_maxbins_10_Rotten Tomatoes Rating\"]) || !isFinite(+datum[\"bin_maxbins_10_Rotten Tomatoes Rating\"]) ? \"null\" : format(datum[\"bin_maxbins_10_Rotten Tomatoes Rating\"], \"\") + \" – \" + format(datum[\"bin_maxbins_10_Rotten Tomatoes Rating_end\"], \"\")) + \"; Count of Records: \" + (format(datum[\"__count\"], \"\"))"
Expand Down Expand Up @@ -191,6 +192,7 @@
"from": {"data": "data_1"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "transparent"},
"stroke": {"value": "#666"},
"ariaRoleDescription": {"value": "point"},
Expand Down Expand Up @@ -313,6 +315,7 @@
"from": {"data": "data_3"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": [
{
"test": "!length(data(\"pts_store\")) || vlSelectionTest(\"pts_store\", datum)",
Expand Down
3 changes: 3 additions & 0 deletions examples/compiled/interactive_crossfilter.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,7 @@
"from": {"data": "data_3"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down Expand Up @@ -675,6 +676,7 @@
"from": {"data": "data_2"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down Expand Up @@ -984,6 +986,7 @@
"from": {"data": "data_0"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": {"value": "#4c78a8"},
"ariaRoleDescription": {"value": "bar"},
"description": {
Expand Down
3 changes: 3 additions & 0 deletions examples/compiled/interactive_dashboard_europe_pop.vg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -606,6 +606,7 @@
"from": {"data": "data_1"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": [
{
"test": "length(data(\"brush_store\")) && vlSelectionTest(\"brush_store\", datum)",
Expand Down Expand Up @@ -933,6 +934,7 @@
"from": {"data": "data_2"},
"encode": {
"update": {
"cursor": {"value": "pointer"},
"fill": [
{
"test": "length(data(\"brush_store\")) && vlSelectionTest(\"brush_store\", datum)",
Expand Down Expand Up @@ -1338,6 +1340,7 @@
"encode": {
"update": {
"opacity": {"value": 0.7},
"cursor": {"value": "pointer"},
"fill": {"value": "transparent"},
"stroke": [
{
Expand Down
Loading