Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve display of price monitoring bounds #6188

Closed
3 tasks
witgaw opened this issue Apr 8, 2024 · 2 comments
Closed
3 tasks

Improve display of price monitoring bounds #6188

witgaw opened this issue Apr 8, 2024 · 2 comments
Assignees
Labels
branch-develop Work for the next planned release of frontend apps

Comments

@witgaw
Copy link
Contributor

witgaw commented Apr 8, 2024

Story

As a console user
I want see price monitoring bounds history in the candles chart
So that I can learn how these evolved over time

Acceptance Criteria (Simplified approach)

Pennant

  • Only show the next bound that will be hit (currently we show all)

Trading view

  • Work out how to get this data into TV
  • Work out how to display it

Sketch

Current state

Bounds are just straight lines and values displayed in the top left corner are either constant or disappear completely for all bounds when market is in auction:
image

Target

Bounds change and values change with time to accurately represent the historical values. When market is in auction only the bounds that were breached dissapear while others are still displayed.

Additional details / background info

Sort thorugh these to find the "nearest" one that will be triggered next

 "priceMonitoringBounds": [
            {
              "minValidPrice": "339341",
              "maxValidPrice": "351772",
              "trigger": {
                "horizon": "360",
                "probability": "0.9999999",
                "auctionExtension": "300"
              },
              "referencePrice": "345502"
            },
            {
              "minValidPrice": "334929",
              "maxValidPrice": "359920",
              "trigger": {
                "horizon": "1440",
                "probability": "0.9999999",
                "auctionExtension": "1800"
              },
              "referencePrice": "347207"
            },
            {
              "minValidPrice": "330030",
              "maxValidPrice": "373839",
              "trigger": {
                "horizon": "4320",
                "probability": "0.9999999",
                "auctionExtension": "3600"
              },
              "referencePrice": "351276"
            },
            {
              "minValidPrice": "305593",
              "maxValidPrice": "403821",
              "trigger": {
                "horizon": "21600",
                "probability": "0.9999999",
                "auctionExtension": "86400"
              },
              "referencePrice": "351410"
            }
@JonRay15
Copy link
Contributor

JonRay15 commented Apr 9, 2024

Was having a poke around on this last night ... I can see this history API.

https://vega-data.nodes.guru:3008/api/v2/market/data/e63a37edae8b74599d976f5dedbf3316af82579447f7a08ae0495a021fd44d13

Which it looks like we can query for given timestamps to / from and we will get every update of the market data from that time window.

https://vega-data.nodes.guru:3008/api/v2/market/data/e63a37edae8b74599d976f5dedbf3316af82579447f7a08ae0495a021fd44d13?startTimestamp=1712651714224286000

Would have to defer to @matt on how useable that is within the context of the chart .... I wonder if a better solution here would be to request a new candle type for this.... how do we handle volume candles @matt?

@JonRay15 JonRay15 moved this from New to Todo in Frontend Engineering Apr 12, 2024
@JonRay15 JonRay15 changed the title Display price monitoring bounds history in the vega chart Improve display of price monitoring bounds Apr 22, 2024
@JonRay15 JonRay15 added the branch-develop Work for the next planned release of frontend apps label Apr 30, 2024
@JonRay15 JonRay15 self-assigned this May 30, 2024
@JonRay15
Copy link
Contributor

Covering this on #6290

We will not show the history ... but we will look at whether we can show the current bounds as a label.

@JonRay15 JonRay15 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Frontend Engineering Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-develop Work for the next planned release of frontend apps
Projects
Archived in project
Development

No branches or pull requests

2 participants