Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to price monitoring bounds #6290

Open
5 tasks
Tracked by #6112
JonRay15 opened this issue Apr 23, 2024 · 1 comment
Open
5 tasks
Tracked by #6112

Improvements to price monitoring bounds #6290

JonRay15 opened this issue Apr 23, 2024 · 1 comment
Assignees
Labels
branch-next Work with dependencies on next Core release

Comments

@JonRay15
Copy link
Contributor

JonRay15 commented Apr 23, 2024

The Chore

There's a few improvements consolidated into here.

Acceptance criteria

Showing bound status

Currently Console is pulling in price monitoring boudns from the market data API. The issue we have is that when those bounds are triggered that API no longer shows the bounds that have been triggered.

There is a core ticket here to try to just get the market data API uplifted to include all bounds even if triggered.

vegaprotocol/vega#11196

Now that the new API has been delivered there is now a flag on the bound showing a boolean for active.

  • Remove the "99.9999% within 6m" and replace with a status of "Active" or "Triggered" based on the boolean above
  • If triggered display it with the hammer auction icon each side of the word to emphasise it
  • Change the values at each end of the bound so that intead of price / USDT across two lines we now do:
    • First line Price and percentage change ie. 63,546 (+14%)
    • Second line CCY ie. USDT

Sketches

Current bound in explorer / accordion

image

@barnabee
Copy link
Member

@JonRay15 this is assigned to me, is there anything you need from me?

@JonRay15 JonRay15 changed the title Ensure we show triggered price monitoring bounds Improvements to price monitoring bounds Jun 20, 2024
@JonRay15 JonRay15 moved this from Backlog to New in Frontend Engineering Jun 20, 2024
@JonRay15 JonRay15 added branch-develop Work for the next planned release of frontend apps and removed refine labels Jun 25, 2024
@JonRay15 JonRay15 moved this from New to Todo in Frontend Engineering Jun 25, 2024
@JonRay15 JonRay15 added branch-next Work with dependencies on next Core release and removed branch-develop Work for the next planned release of frontend apps labels Jun 25, 2024
@JonRay15 JonRay15 moved this from Todo to Backlog in Frontend Engineering Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch-next Work with dependencies on next Core release
Projects
Status: Backlog
Development

No branches or pull requests

2 participants