Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API]: Show triggered bounds on market data API #11196

Closed
4 tasks
JonRay15 opened this issue Apr 25, 2024 · 1 comment · Fixed by #11213
Closed
4 tasks

[API]: Show triggered bounds on market data API #11196

JonRay15 opened this issue Apr 25, 2024 · 1 comment · Fixed by #11213
Assignees
Labels
api fe-request A list of reasonably high value API change requests from front end

Comments

@JonRay15
Copy link

JonRay15 commented Apr 25, 2024

API Overview

In order to ... make price monitoring bounds clearer
We will build an API to... expose all bounds including triggered ones on the market data API
So that ... it is very clear the full set of bounds on a market, which have triggered, and which have not

API request details

  • Show ALL price monitoring bounds even once they are triggered (currently once they are triggered they are not shown)
  • Include some "status" on each bound which would be say "active" or "triggered"
  • When a bound has been triggered we'd need to display "null" or "na" or similar for the referencePrice, minValidPrice, and maxValidPrice presumably

Filtering requirements (inputs)

  • None

Sample API output (optional)

Current API output

"priceMonitoringBounds": [
{
"minValidPrice": "626861",
"maxValidPrice": "649827",
"trigger": {
"horizon": "360",
"probability": "0.9999999",
"auctionExtension": "300"
},
"referencePrice": "638244"
},
{
"minValidPrice": "618730",
"maxValidPrice": "664897",
"trigger": {
"horizon": "1440",
"probability": "0.9999999",
"auctionExtension": "1800"
},
"referencePrice": "641413"
},
{
"minValidPrice": "603653",
"maxValidPrice": "683785",
"trigger": {
"horizon": "4320",
"probability": "0.9999999",
"auctionExtension": "3600"
},
"referencePrice": "642514"
},
{
"minValidPrice": "558662",
"maxValidPrice": "738235",
"trigger": {
"horizon": "21600",
"probability": "0.9999999",
"auctionExtension": "86400"
},
"referencePrice": "642422"
}
],

Additional Details (optional)

Any additional information that provides context or gives information that will help us develop the feature.

@JonRay15 JonRay15 added the api label Apr 25, 2024
@JonRay15 JonRay15 added the fe-request A list of reasonably high value API change requests from front end label Apr 25, 2024
@JonRay15 JonRay15 changed the title [API]: [API]: Show triggered bounds on market data API Apr 25, 2024
@JonRay15
Copy link
Author

Barney is considering options here

@jeremyletang jeremyletang added this to the 🏛️ Colosseo milestone Apr 29, 2024
@jeremyletang jeremyletang moved this to Todo in Core Kanban Apr 29, 2024
@vega-issues vega-issues moved this from Todo to In Progress in Core Kanban Apr 29, 2024
@vega-issues vega-issues moved this from In Progress to Waiting Review in Core Kanban May 10, 2024
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban May 10, 2024
@vega-issues vega-issues moved this from Approved to In Review in Core Kanban May 13, 2024
@vega-issues vega-issues moved this from In Review to Approved in Core Kanban May 14, 2024
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api fe-request A list of reasonably high value API change requests from front end
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants