feat(trading): gas fee estimation for withdraw transaction #5668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asiaznik
force-pushed
the
feat/5510-gas-withdrawal
branch
from
a617846 to
bb999c0
Compare
|
Previews
|
MadalinaRaicu
approved these changes
Jan 30, 2024
edd
approved these changes
Jan 31, 2024
asiaznik
force-pushed
the
feat/5510-gas-withdrawal
branch
from
ba604fb to
c81507b
Compare
asiaznik
force-pushed
the
feat/5510-gas-withdrawal
branch
from
c81507b to
1af78d6
Compare
daro-maj
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues 🔗
Closes #5510
Description ℹ️
This PR adds the gas fee estimation for the
<WitdrawLimits>component. It colours the prices orange if the amount it between base and max price, and red if it's below the base fee.Demo 📺
Shows in ETH when price is >1e6 gwei:
Technical 👨🔧
The withdrawal amount (any asset) is only somewhat comparable to the estimated gas (ETH) fee only if they're both equalised to qUSD. This PR also adds the
useWETHhook which looks for theWETHconfiguration (quantum is really what's needed) in the Vega's assets (it returns hardcoded values if not found, 1 WETH ~= 2000 qUSD).