Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create API for AMM range details #11023

Closed
15 tasks
Tracked by #11019
JonRay15 opened this issue Mar 27, 2024 · 0 comments · Fixed by #11382
Closed
15 tasks
Tracked by #11019

Create API for AMM range details #11023

JonRay15 opened this issue Mar 27, 2024 · 0 comments · Fixed by #11382
Assignees

Comments

@JonRay15
Copy link

JonRay15 commented Mar 27, 2024

API Overview

We require an API that provides the details of all AMM shapes on a given market so we can show these to users.

API request details

  • Provide the followin details of all shapes
    • Party ID
    • Derived Party ID
    • Market ID
    • Commitment
    • Slippage tolerance
    • Proposed fee
    • Base price
    • Lower price
    • Upper price
    • Margin ratio at upper bound
    • Margin ratio at lower bound

Filtering requirements (inputs)

  • Market ID
  • Party ID
  • Derived Party ID

Sample API output (optional)

Dont think this is needed for this 

Questions

None

API test scenarios

Detailed scenarios that can be executed as feature tests to verify that the API has been implemented as expected.

GIVEN (setup/context)
WHEN (action)
THEN (assertion) For example...
See here for more format information and examples.

Additional Details (optional)

Any additional information that provides context or gives information that will help us develop the feature.

@JonRay15 JonRay15 added the api label Mar 27, 2024
@gordsport gordsport moved this to Todo in Core Kanban Mar 27, 2024
@jeremyletang jeremyletang added this to the 🏛️ Colosseo milestone May 1, 2024
@jeremyletang jeremyletang self-assigned this May 14, 2024
@jeremyletang jeremyletang removed their assignment Jun 14, 2024
@EVODelavega EVODelavega self-assigned this Jun 14, 2024
@vega-issues vega-issues moved this from Todo to Waiting Review in Core Kanban Jun 14, 2024
@vega-issues vega-issues moved this from Waiting Review to Approved in Core Kanban Jun 14, 2024
@github-project-automation github-project-automation bot moved this from Approved to Merged in Core Kanban Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants