Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create API to provide subkeys for a given key #11024

Closed
6 tasks
JonRay15 opened this issue Mar 27, 2024 · 1 comment
Closed
6 tasks

Create API to provide subkeys for a given key #11024

JonRay15 opened this issue Mar 27, 2024 · 1 comment

Comments

@JonRay15
Copy link

JonRay15 commented Mar 27, 2024

API Overview

As part of the AMM implementation, keys can now have a subkey from which the AMM commitment is handled.

As a result we need a way to link from the parent key to its subkeys.

I have included on #11023 the potential option to just include the parent key on the AMM shape, which might be a simple way to handle this since I think right now subkey and parent key are always 1-2-1?

But maybe it is better to have an API for this in case we have more subkeys of more types later? So including this so it can be considered.

API request details

  • Create an API listing parent keys and providing for each parent key
    • Any subkeys
    • The type of subkey (vAMM, other)

Filtering requirements (inputs)

  • Parent key
  • Subkey
  • Type

Questions

TBC

API test scenarios

Detailed scenarios that can be executed as feature tests to verify that the API has been implemented as expected.

GIVEN (setup/context)
WHEN (action)
THEN (assertion) For example...
See here for more format information and examples.

Additional Details (optional)

Any additional information that provides context or gives information that will help us develop the feature.

@JonRay15 JonRay15 changed the title Create API to provide subjects for a given key Create API to provide subkeys for a given key Mar 27, 2024
@gordsport gordsport moved this to Todo in Core Kanban Mar 27, 2024
@JonRay15
Copy link
Author

JonRay15 commented Apr 9, 2024

Now covered elsewhere

@JonRay15 JonRay15 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 9, 2024
@github-project-automation github-project-automation bot moved this from Todo to Merged in Core Kanban Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants