return false when rule not found #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@indutny throwing when rule not found appears to change semantics and break things. No idea why and I can't give you a small enough case. Returing false is what it used to do before. I assume failure to find a rule is a legit way for match to fail and backtrack. Could you pls check it. Thx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@indutny throwing when rule not found appears to change semantics and
break things. No idea why and I can't give you a small enough case.
Returing false is what it used to do before. I assume failure to find a
rule is a legit way for match to fail and backtrack. Could you pls check it. Thx
Maybe some reporting is warranted here if only for debugging, like pushing
'Rule: ' + rule + ' not found'on some error stack to report in case backtracking fails.