Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to increase instance search depth #873

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

MatthewDaggitt
Copy link
Collaborator

Some of the tensor constraints about to be added require a deeper instance search than is currently available. This PR therefore:

  • stores constraints solved by standard instance search separately from constraints solved by non-standard solvers (e.g. size solvers for Index constraints, polarity, linearity constraints)
  • implements a depth counter for instance search and recursively calls it until the depth counter is exceeded. I hopefully on envisage ever needed a depth of 1.
  • increases the depth counter to 1 only if we can make no further progress at depth 0.

No performance regressions in type-checking detected.

@MatthewDaggitt MatthewDaggitt added this to the v0.16 milestone Dec 16, 2024
@MatthewDaggitt MatthewDaggitt added this pull request to the merge queue Dec 16, 2024
Merged via the queue into dev with commit e8c3b18 Dec 16, 2024
20 checks passed
@MatthewDaggitt MatthewDaggitt deleted the instance-search branch December 16, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant