Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make reproducable importer #112

Merged
merged 4 commits into from
Apr 15, 2021
Merged

make reproducable importer #112

merged 4 commits into from
Apr 15, 2021

Conversation

vvakame
Copy link
Collaborator

@vvakame vvakame commented Oct 9, 2019

current importer can't reproducable.
We can't know what version of graphql-js does we use?.

Current implementations use e6c36e0725ea0aabad1a19c68e54180fb7092e3a.

latest commit of values_of_correct_type.go is Jul 19, 2018.
https://github.com/vektah/gqlparser/commits/master/validator/rules/values_of_correct_type.go

I picked up it from https://github.com/graphql/graphql-js/commits/master/src/validation/rules/ValuesOfCorrectType.js .
e6c36e is made at Jul 18, 2018.


So, I tried to update latest one. But I can't solve flowtype issue... 😿

SyntaxError: .../gqlparser/validator/imported/graphql-js/src/error/GraphQLError.js: Identifier 'GraphQLError' has already been declared (86:16)

  84 | }
  85 |
> 86 | export function GraphQLError( // eslint-disable-line no-redeclare
     |                 ^
  87 |   message: string,
  88 |   nodes?: $ReadOnlyArray<ASTNode> | ASTNode | void,
  89 |   source?: ?Source,

https://github.com/vvakame/gqlparser/commits/improve-importer-r3
vvakame@895df5c

Do you advanced to babel & flowtype ...?

@vvakame vvakame requested a review from vektah October 9, 2019 07:58
@coveralls
Copy link

coveralls commented Oct 9, 2019

Coverage Status

Coverage remained the same at 92.171% when pulling 5784280 on vvakame:improve-importer-r2 into 7cc8073 on vektah:master.

@vvakame
Copy link
Collaborator Author

vvakame commented Apr 13, 2021

@lwc Hi, I updated this old PR.
I heard @Code-Hex wanna try to update spec.
This PR is the 1st step to it.

@vvakame vvakame requested a review from lwc April 13, 2021 09:19
@lwc lwc merged commit 5a9c950 into vektah:master Apr 15, 2021
@vvakame vvakame deleted the improve-importer-r2 branch April 15, 2021 02:10
@StevenACoffman
Copy link
Collaborator

@vvakame Hey, so I'm noticing this is causing some problems with 99designs/gqlgen#1857 and Khan/genqlient#166 that I wonder if you have any insights into?

@vvakame
Copy link
Collaborator Author

vvakame commented Jan 31, 2022

sorry, I don't have any insight. what is the problem?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants