Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for vektah/gqlparser#281 #282

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix for vektah/gqlparser#281 #282

merged 1 commit into from
Sep 15, 2023

Conversation

Metamogul
Copy link
Contributor

@Metamogul Metamogul commented Sep 14, 2023

This PR fixes the issue described in #281.

Included:

  • Fix
  • Added missing tests

@coveralls
Copy link

Coverage Status

coverage: 88.689% (+0.3%) from 88.386% when pulling f53058d on Metamogul:master into d734cf8 on vektah:master.

@StevenACoffman StevenACoffman merged commit cb1d657 into vektah:master Sep 15, 2023
1 of 2 checks passed
StevenACoffman added a commit that referenced this pull request Sep 15, 2023
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@StevenACoffman
Copy link
Collaborator

StevenACoffman commented Sep 15, 2023

thanks! I really appreciate the test coverage!

StevenACoffman added a commit that referenced this pull request Sep 15, 2023
Signed-off-by: Steve Coffman <steve@khanacademy.org>
@yuki2006
Copy link

Thank you for the useful library. I would appreciate it if you could tag a hotfix version soon, as the impact is significant.

@StevenACoffman
Copy link
Collaborator

Ok, I have tagged and released a new version of gqlparser, as well as updated gqlgen to that version, and tagged and released a new version of gqlgen.

Sorry for the inconvenience.

@Metamogul
Copy link
Contributor Author

Thank you! And no need to be sorry - thank you for maintaining such an awesome and useful lib!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants