Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring external deps using glide #138

Closed
wants to merge 3 commits into from

Conversation

tamccall
Copy link
Contributor

@tamccall tamccall commented Apr 1, 2017

No description provided.

@codeactual
Copy link
Contributor

If glide doesn't support vendor pruning [1, 2], it still might be worthwhile to do it via find in the Makefile (example) after each fetch.

This commit, and any future one to upgrade deps, will contain all sorts of files that aren't licenses or built (e.g. txt, javascript, etc.).

@tamccall
Copy link
Contributor Author

tamccall commented Apr 1, 2017

@codeactual added a glide up target in the Makefile based off of the example you gave that will perform glide up and remove unnecessary files

@tamccall
Copy link
Contributor Author

tamccall commented Jun 2, 2017

Ran into this guy the other day would likely resolve @codeactual issues with unnecessary code in the vendor directory

@tamccall tamccall force-pushed the vendoring branch 6 times, most recently from d07ed35 to bab2f29 Compare June 3, 2017 23:27
@tamccall tamccall force-pushed the vendoring branch 2 times, most recently from 2a19028 to 1d59ff9 Compare June 3, 2017 23:57
@tamccall tamccall force-pushed the vendoring branch 3 times, most recently from 62199c3 to 54090a0 Compare June 4, 2017 01:46
@evanphx
Copy link
Member

evanphx commented Aug 15, 2018

This is an oldie. I probably should vendor them but I'd do so with dep now instead.

@evanphx evanphx closed this Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants