Fixing #291 where a different import with the same name as the package would not get included in the mock #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…package would not get included in the mock
|
Thanks for the PR, I'll get this reviewed within the next day or so and we can get it merged. |
|
(I haven't forgotten about this, will probably get to it on the weekend) |
This was referenced Jun 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the issue from #291. The inconsistency there came from
FormatOnlybeing set to false when re-formating the file because it is allowed to add/remove imports.The logic for the test that was edited came from a test that was not quite right in #143 and in turn was enforcing that this bug existed. It was kind of testing what is was looking for but not correctly so I added a proper test to validate it. I could not make the test fail with the previous code though without putting a more full
pkgpath in the tests.